Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect setting of result_t #1130

Merged
merged 2 commits into from
Nov 17, 2024
Merged

remove incorrect setting of result_t #1130

merged 2 commits into from
Nov 17, 2024

Conversation

jmitrevs
Copy link
Contributor

Description

The result_t was incorrect set in the MergeLinearActivation optimizer. This removes the setting, which wasn't needed anyway. Setting get_output_variable().type.precision already sets it properly as a side-effect.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

This fixes a bug found in #1122. The test is there.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the bug label Nov 15, 2024
@jmitrevs jmitrevs added this to the v1.0.0 milestone Nov 15, 2024
@jmitrevs jmitrevs marked this pull request as draft November 15, 2024 23:15
@jmitrevs
Copy link
Contributor Author

A few more optimizers also needlessly (and incorrectly) set result_t, so I removed those, too.

@bo3z bo3z merged commit e778ed3 into main Nov 17, 2024
7 checks passed
@bo3z bo3z deleted the result_t_bug_fix branch November 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants